From aef29daad94189fb5dd5fc97bccf49ff9dbba661 Mon Sep 17 00:00:00 2001 From: mat Date: Mon, 20 Jan 2025 05:49:13 +0000 Subject: [PATCH] remove negative checks for box_shape --- azalea-physics/src/collision/shape.rs | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/azalea-physics/src/collision/shape.rs b/azalea-physics/src/collision/shape.rs index 9d870498..b0dceabb 100755 --- a/azalea-physics/src/collision/shape.rs +++ b/azalea-physics/src/collision/shape.rs @@ -26,24 +26,9 @@ pub fn box_shape( max_y: f64, max_z: f64, ) -> VoxelShape { - assert!(min_x >= 0., "min_x must be >= 0 but was {min_x}"); - assert!(min_y >= 0.); - assert!(min_z >= 0.); - assert!(max_x >= 0.); - assert!(max_y >= 0.); - assert!(max_z >= 0.); + // we don't check for the numbers being out of bounds because some blocks are + // weird and are outside 0-1 - box_shape_unchecked(min_x, min_y, min_z, max_x, max_y, max_z) -} - -pub fn box_shape_unchecked( - min_x: f64, - min_y: f64, - min_z: f64, - max_x: f64, - max_y: f64, - max_z: f64, -) -> VoxelShape { if max_x - min_x < EPSILON && max_y - min_y < EPSILON && max_z - min_z < EPSILON { return EMPTY_SHAPE.clone(); } @@ -591,7 +576,7 @@ impl VoxelShape { impl From for VoxelShape { fn from(aabb: AABB) -> Self { - box_shape_unchecked( + box_shape( aabb.min.x, aabb.min.y, aabb.min.z, aabb.max.x, aabb.max.y, aabb.max.z, ) }